Test Results

  7 files  ±0   53 suites  ±0   5m 54s ⏱️ +22s
185 tests ±0  168 ✅ ±0  17 💤 ±0  0 ❌ ±0 
692 runs  ±0  624 ✅ ±0  68 💤 ±0  0 ❌ ±0 

Results for commit 9428e1e. ± Comparison against base commit c3bf42e.

♻️ This comment has been updated with latest results.

My 2 cents no need to update here in sync. ?
https://github.com/Open-CMSIS-Pack/Open-CMSIS-Pack-Spec/blob/f44cfe46e611ca14d63e3dc84ddf5793a4912d68/schema/PACK.xsd#L1377

Hello @brondani, have you seen the changes that were addressed?

Hello @brondani, have you seen the changes that were addressed?

@Hermann-Core Many thanks for this contribution. I am currently busy with the schedule for the upcoming 2.7.0 release, I am planning to test and accurately review you PR in the beginning of the next week.
It would be helpful if we also create a default linker script for TICLANG, e.g. for CLANG:
https://github.com/Open-CMSIS-Pack/devtools/blob/main/tools/projmgr/templates/clang_linker_script.ld.src
Is this something you would be willing to take care?

@Hermann-Core Many thanks for this contribution. I am currently busy with the schedule for the upcoming 2.7.0 release, I am planning to test and accurately review you PR in the beginning of the next week. It would be helpful if we also create a default linker script for TICLANG, e.g. for CLANG: https://github.com/Open-CMSIS-Pack/devtools/blob/main/tools/projmgr/templates/clang_linker_script.ld.src Is this something you would be willing to take care?

Ok I will do it as soon as I can

@Hermann-Core Yesterday I brought the question about the compiler name convention to the Open CMSIS Pack meeting.
Considering we will potentially support more variants of standard compilers such as GCC and CLANG, our tendency at the moment is to name the variant with a short identifier after the common name: <common compiler name>_<variant id>, in this case CLANG_TI.
So I have renamed it and patched this PR, also adding a placeholder for the default linker file so I could run some local tests. So far so good.
Once you have a suitable linker script to propose please open a new PR.
Thanks again for the contribution!

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 65.16%. Comparing base (c3bf42e) to head (9428e1e).
Report is 1 commits behind head on main.

@@           Coverage Diff           @@
##             main    #1887   +/-   ##
=======================================
  Coverage   65.16%   65.16%           
=======================================
  Files         173      173           
  Lines       34850    34850           
  Branches    20227    20227           
=======================================
  Hits        22709    22709           
  Misses       7960     7960           
  Partials     4181     4181           

Considering we will potentially support more variants of standard compilers such as GCC and CLANG, our tendency at the moment is to name the variant with a short identifier after the common name: <common compiler name>_<variant id>, in this case CLANG_TI. So I have renamed it and patched this PR,

It makes a lot of sense to me.

Once you have a suitable linker script to propose please open a new PR. Thanks again for the contribution!

Understood, I’ll prepare the linker script and open a new PR once done. Thanks for the review!